[MGNLWORKFLOW-349] Deletion workflow message should not be identical to publishing changes Created: 30/Jan/17 Updated: 20/Mar/17 Resolved: 16/Mar/17 |
|
| Status: | Closed |
| Project: | Magnolia Workflow Module |
| Component/s: | None |
| Affects Version/s: | 5.4.7 |
| Fix Version/s: | 5.5.4, 5.6.2 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Robert Šiška | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 2d 3h | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Sprint: | Basel 87 | ||||||||||||||||||||
| Story Points: | 8 | ||||||||||||||||||||
| Description |
|
Deletion workitems and messages have exactly the same title as publishing workitems and messages: "Publication request for /x/y/z". A publisher can't tell by looking at the message that this is in fact a deletion. It should be obvious from the message. Use a different title for deletion workitems and messages:
|
| Comments |
| Comment by Robert Šiška [ 30/Jan/17 ] |
|
Pull request: https://git.magnolia-cms.com/projects/ENTERPRISE/repos/workflow/pull-requests/15/overview |
| Comment by Evzen Fochr [ 06/Feb/17 ] |
|
This ticket was one and only in WF5.5.4. Removed this version from 5.4.11 changelog. |
| Comment by Robert Šiška [ 13/Feb/17 ] |
|
Reverted from master. |
| Comment by Antti Hietala [ 01/Mar/17 ] |
|
Invest the time to change both the workitem title in the Pulse list view and the message title in the message view. It's important that the list view also shows the difference. Edited description, attached screenshots. |
| Comment by Michael Mühlebach [ 02/Mar/17 ] |
|
amanzoni Could you add the patch/PR/hint to your solution? |
| Comment by Adrien Manzoni [ 02/Mar/17 ] |
|
Sure, I'll try to make it this afternoon |
| Comment by Espen Jervidalo [ 02/Mar/17 ] |
|
For the title in the detail-view, we already have means to change it quite easily: info.magnolia.module.workflow.jbpm.humantask.view.PublicationTaskPresenter#setItemViewTitle For the list view, things are not that easy. It's hard-coded and an inlined class: The title resolving-"strategy" should be bound to the task/message-type. |