[MGNLWORKFLOW-371] Don't use deprecated DialogDefinitionRegistry#getDialogDefinition in WorkflowFormDialogPresenter Created: 16/Aug/18  Updated: 17/Aug/18  Resolved: 16/Aug/18

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: None
Fix Version/s: 5.7.2

Type: Bug Priority: Neutral
Reporter: Milan Divilek Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Sprint: Kromeriz 158
Story Points: 1

 Description   

info.magnolia.module.workflow.action.WorkflowFormDialogPresenter uses deprecated (from 5.4) method info.magnolia.ui.dialog.registry.DialogDefinitionRegistry#getDialogDefinition.



 Comments   
Comment by Milan Divilek [ 16/Aug/18 ]

Method was removed in 6.0 and it cause https://jenkins.magnolia-cms.com/job/ee/job/master/561/

Caused by: java.lang.NoSuchMethodError: info.magnolia.ui.dialog.registry.DialogDefinitionRegistry.getDialogDefinition(Ljava/lang/String;)Linfo/magnolia/ui/dialog/definition/FormDialogDefinition;
	at info.magnolia.module.workflow.action.WorkflowFormDialogPresenter.start(WorkflowFormDialogPresenter.java:83) ~[magnolia-module-workflow-5.7.1.jar:?]
	at info.magnolia.module.workflow.action.OpenPublicationDialogAction.execute(OpenPublicationDialogAction.java:59) ~[magnolia-module-workflow-5.7.1.jar:?]
	at info.magnolia.ui.api.action.AbstractActionExecutor.execute(AbstractActionExecutor.java:62) ~[magnolia-ui-api-6.0-SNAPSHOT.jar:?]
Generated at Mon Feb 12 10:09:25 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.