[MGNLWORKFLOW-407] Show changes in task detail opens the compatibility pages app Created: 05/Dec/21  Updated: 02/Feb/24  Resolved: 14/Apr/23

Status: Closed
Project: Magnolia Workflow Module
Component/s: Pages Integration
Affects Version/s: 6.0.5
Fix Version/s: 7.0.0, 6.0.9

Type: Bug Priority: Neutral
Reporter: Richard Gange Assignee: Thuy To
Resolution: Fixed Votes: 4
Labels: VN-Analysis, diff
Remaining Estimate: 0d
Time Spent: 9d 5.25h
Original Estimate: Not Specified

Attachments: PNG File image-2023-04-11-16-08-40-707.png     PNG File image-2023-04-11-16-09-44-406.png     PNG File image-2023-04-11-16-17-01-861.png     PNG File image-2023-04-11-16-30-03-321.png     PNG File image-2023-04-11-16-31-38-411.png     PNG File pages-app-diff.png     PNG File show-changes.png    
Issue Links:
Cloners
is cloned by MGNLWORKFLOW-442 CLONE - Show changes in task detail o... Open
causality
duplicate
is duplicated by PAGES-1077 Adding component while page is not pu... Closed
relation
is related to MGNLWORKFLOW-384 Port workflow to new UI framework Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: AuthorX Support
Story Points: 5
Team: AuthorX
Work Started:
Approved:
Yes

 Description   

Currently the show changes button in the task detail opens the old pages app.

Reproduce

  1. Publish a page
  2. Open the task in detail view (Assign to me - Preview task)
  3. Click "Show changes" from the actionbar
  4. The compatibility pages app opens

Expected
The preview should open the new pages app.

Actual
The compatibility pages app opens

Notes
Currently an action from the workflow compatibility module is being used which is hard coded for the compatibility pages app WorkItemLocalizedDiffAction.

I tried uninstalling the workflow compatibility module. When trying to click shows changes I end up with:

It seems we should be using WorkItemDiffAction for the show changes button. See MGNLWORKFLOW-384.



 Comments   
Comment by Thuy To [ 11/Apr/23 ]

Hi ldelnevo

Please help me review this problem after it's fixed.

+ Before: the show change dialog with old action

 

+ After: Show change dialog adapting with new action

 

As expectation, we have updated the action in messageViews for the show changes button.

 

Thank you :bow:

Generated at Mon Feb 12 10:09:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.