[MGNLWORKFLOW-60] Pulse Subapp: Display success and error notifications when approving and rejecting workflows. Created: 25/Apr/13  Updated: 27/Jun/13  Resolved: 26/Apr/13

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Improvement Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLUI-1205 As a user I am notified if working wi... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Pulse SubApp: Message View

  • When user clicks Approve/Reject: Show notifications.


 Comments   
Comment by Daniel Lipp [ 26/Apr/13 ]
  • ApproveWorkflowAction & RefectWorkflowAction are almost identical. Pls checkout out how implement it in a more DRY way. Maybe have a commons superclass?
  • pls add unittest for the action(s)
  • as the messages in the ~Definition types are hardcoded they should rather be defined as public static final Strings than being returned from ordinary methods
Comment by Christopher Zimmermann [ 26/Apr/13 ]

ApproveWorkflowAction and RejectWorkflowAction now extend new Abstract class: AbstractWorkflowDispatchAction.

Unit tests added for all 3 classes.

For the third point - these methods (getErrorMessage, getSuccessMessage, etc) now override methods in ActionDefinition.
ActionDefinition has been changed in ui branch workflow-notifications as specified in UI ticket: http://jira.magnolia-cms.com/browse/MGNLUI-1224

Comment by Christopher Zimmermann [ 29/Apr/13 ]

Implemented all recommendations.

Generated at Mon Feb 12 10:06:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.