|
info.magnolia.module.workflow.jbpm.persistence.JcrProcessInstanceManager#addProcessInstance
- put context.close() in finally and baos should also be closed in a finally clause.
- looks like the exception handling is not solid? why call baos.toByteArray if writing the context fails? shouldn't it just fail? correct me otherwise
- newProcessInstance.setProperty(WorkflowNodeTypes.WorkItem.BYTES, new ByteArrayInputStream(newByteArray)); is deprecated
remove
info.magnolia.module.workflow.jbpm.persistence.ProcessInstanceIdGenerator mapping from module descriptor
|
|
Sorry just saw you are using Components.getComponent for ProcessInstanceIdGenerator. Maybe extract an interface in that case, so you actually can replace the implementation? otherwise ignore remark
|
|
Thx for the hint - I actually considered that option but felt like it's overhead to introduce an interface here. The id is only used internally. In case someone really, really, wants to change it he can always overwrite JcrProcessInstanceManager#createId()
|
|
stop - remove has not yet been adapted to the new storage in structure
|
Generated at Mon Feb 12 10:06:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.