[MGNLXAA-85] Merge exchange-transactional app into activation Created: 15/Aug/14  Updated: 29/Aug/14  Resolved: 28/Aug/14

Status: Closed
Project: Transactional Activation
Component/s: None
Affects Version/s: 2.1.4
Fix Version/s: 2.2

Type: Task Priority: Neutral
Reporter: Evzen Fochr Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLACTIVATION-72 Merge activation tools app and activa... Closed
is related to MGNLXAA-86 Update version of commons-lang Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Comments   
Comment by Evzen Fochr [ 18/Aug/14 ]

MGNLXAA-85 need at least common-lang 2.4 (2.3 now) for working upgrade and tests

Comment by Roman Kovařík [ 25/Aug/14 ]
  1. Update also dependency to activation in src/main/resources/META-INF/magnolia/exchange-transactional.xml
  2. Please group all related tasks into one ArrayDelegateTask
  3. Use class names instead of plain Strings.
  4.  
    protected List<Task> getExtraInstallTasks(InstallContext installContext) {
            List<Task> tasks = new ArrayList<Task>();
            tasks.addAll(super.getExtraInstallTasks(installContext));
    

    could be simplified to:

    protected List<Task> getExtraInstallTasks(InstallContext installContext) {
            List<Task> tasks = super.getExtraInstallTasks(installContext);
            tasks.add(setActivationSubAppClass);
    
Comment by Roman Kovařík [ 27/Aug/14 ]

I was wrong with 3)...it was correct, the method returns empty list which is not able to add an element. Sorry about that. Otherwise looks OK.

Generated at Mon Feb 12 11:06:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.