[MGNLXLS-8] SaveHandler or ParagraphRenderer Created: 17/May/07  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Excel Renderer (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Task Priority: Major
Reporter: Magnolia International Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

I couldnt' manage to put the pre-rendering logic in a SaveHandler, mostly because it doesn't have a "postSave" hook. Using the one from the dialog could have worked - if there'd be a clean way to get the "save node".
Also, this introduced a dependecy on HierarchyManager, which would break 3.0 / 3.1 compatibility since the HierarchyManager changed package. *

Instead now, the logic is called by the excel.jsp, which is similar but less elegant than having this in a ParagraphRenderer.
The SaveHandler still exists, but only removes the "pre-rendered" property if it had been previously created.

Let's review this.

  • since we will also move the NodeData and Content classes to interfaces in the api package, breakage will happen anyway. I guess we'll need to do parallel releases.


 Comments   
Comment by Philipp Bracher [ 22/May/07 ]

You should be able to get the "save node" by using getStorageNode()

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 01:46:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.