[MPBUN-7] Cyclic dependency between maven-bundle-plugin and magnolia (reactor) Created: 04/Oct/06  Updated: 16/Mar/23  Resolved: 16/Mar/23

Status: Closed
Project: Bundle Maven Plugin (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1

Type: Task Priority: Minor
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Magnolia can't be built (with reactor or just -core, for instance), without maven-bundle-plugin. But maven-bundle-plugin also needs magnolia-core to build itself.
This only shows up if you're in offline mode and have none of these 2 in your local repo. It would also happen when trying to build a new version.
Not sure how to resolve this though, but I'm suspecting the maven-bundle-plugin is only used/useful when actually building the bundles - i.e not from reactor but only through the bundle.sh script.
If that's the case, then I don't think the maven-bundle-plugin needs to be referenced at all in magnolia's parent pom or it could just be activated in the magnolia module, and simply "registered" in the main pom using <pluginManagement> (and then be part of the reactor'd build)



 Comments   
Comment by Magnolia International [ 10/Oct/06 ]

Ok so this is a bit more complex than I expected.

As a first step, the plugin is now in <pluginManagement> so at least one can build magnolia without having to have or build the maven-bundle-plugin.

Making maven-bundle-plugin independent from magnolia-core is a chicken/egg problem that would require a couple of changes to the way maven-bundle-plugin works, and possibly the extraction of a couple of magnolia-core utility classes in a separate module.

Comment by Magnolia International [ 08/Sep/08 ]

This dependency is there because of the bootstrapping process which was executed when doing a release. Since this is not the case anymore, the easiest would simply be to get rid of the BootstrapMojo. We might want to provide a tool to bootstrap specific files though.

Comment by Adam Jones [ 16/Mar/23 ]

Closing due to project being archived.

Generated at Sun Feb 11 23:49:29 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.