[MSHOP-126] Missing i18n properties Created: 04/Mar/14  Updated: 24/Apr/15  Resolved: 24/Apr/15

Status: Closed
Project: Magnolia Shop (closed)
Component/s: None
Affects Version/s: 2.0
Fix Version/s: 2.0.1, 2.1.1, 2.2

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Antonín Juran
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File dialog1.png     PNG File dialog2.png     PNG File shopConfirmTerm.png    
Issue Links:
Relates
relates to MAGNOLIA-5700 Add i18n properties for checkboxes Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Not sure if shopConfirmTerms dialog is used somewhere, but it is boostrapped, see shopConfirmTerm.png:

  • shop.shopConfirmTerms.tabMain.title.label
  • shop.shopConfirmTerms.tabMain.controlName.label
  • shop.shopConfirmTerms.tabMain.mandatory.label
  • dialog.form.edit.tabMain.mandatory.buttonLabel (caused by MGNLUI-2663, comes from UI, maybe is extended or has hardcoded key)


 Comments   
Comment by Milan Divilek [ 13/Feb/15 ]

Reopen: When we are in updating i18n titles/labes/... there is bunch of hardcoded texts in template definitions.
For example:
/modules/shop/templates/pages/shopCheckoutForm@title
/modules/shop/templates/components/features/shopProductDetail@title
...

Please try to find all of them and use i18n for them.

Comment by Jan Haderka [ 23/Feb/15 ]

Don't see anywhere missing changes mentioned from first review. Maybe they are not pushed yet?

Comment by Antonín Juran [ 23/Feb/15 ]

Wasn't pushed on remote branch.

Comment by Milan Divilek [ 02/Mar/15 ]

Reopen: https://jenkins.magnolia-cms.com/job/int_migration-tests_5.2-to-5.3.x-branch/678/Diff_Reports/

Comment by Antonín Juran [ 02/Mar/15 ]

Fixed on branch MSHOP-126_3

Comment by Milan Divilek [ 02/Mar/15 ]

Reopen:
Why are you changing i18n keys? For example in /mgnl-bootstrap/shop/paragraphs/config.modules.shop.templates.components.teasers.shopProductTeaser.xml you changed description i18n key from "paragraphs.teasers.shopProductTeaser.description" to "shop.templates.components.teasers.shopProductTeaser.description". Why was this necessary? And why you let the old (unused) i18n key in messages.properties file?

Same for example for "areas.components.linkList.description" which was change to "shop.templates.components.teasers.shopProductTeaser.areas.linkList.description"

Comment by Roman Kovařík [ 17/Apr/15 ]

Missing i18n:
shop.templates.pages.shopCheckoutForm.title
shop.templates.pages.shopFormStep.title
shop.templates.pages.shopFormStepConfirmOrder.title
dialog shopConfirmTerms has no title when opened

And you can also fix another issue:

2015-04-17 13:01:10,389 ERROR info.magnolia.jcr.wrapper.ExtendingNodeWrapper    : Can't find referenced node for value: node /modules/shop/templates/components/features/form/shopConfirmTerms
Comment by Antonín Juran [ 19/Apr/15 ]

Fixed on branch MSHOP-126_4

Comment by Milan Divilek [ 23/Apr/15 ]

Reopen:
Wrong action bar section is resolved for Folders. This is because shoppingCarts extends configuration app where /modules/ui-admincentral/apps/configuration/subApps/browser/actionbar/sections/folders/availability/nodeTypes@folder is set to mgnl:content, but folders in shoppingCarts are mgnl:folder.

i18n key shoppingCarts.browser.actionbar.sections.multiple.label key has wrong value "Folder"
i18n key shoppingCarts.browser.actionbar.sections.folders.label is missing

Missing i18n for sampleShopShoppingCarts apps. For example:
sampleShopShoppingCarts.browser.actionbar.sections.folders.label
sampleShopShoppingCarts.browser.actionbar.sections.nodes.label
etc.

Comment by Antonín Juran [ 24/Apr/15 ]

Fixed on branch MSHOP-126_5

Generated at Mon Feb 12 07:09:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.