[MSHOP-126] Missing i18n properties Created: 04/Mar/14 Updated: 24/Apr/15 Resolved: 24/Apr/15 |
|
| Status: | Closed |
| Project: | Magnolia Shop (closed) |
| Component/s: | None |
| Affects Version/s: | 2.0 |
| Fix Version/s: | 2.0.1, 2.1.1, 2.2 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Antonín Juran |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Not sure if shopConfirmTerms dialog is used somewhere, but it is boostrapped, see shopConfirmTerm.png
|
| Comments |
| Comment by Milan Divilek [ 13/Feb/15 ] |
|
Reopen: When we are in updating i18n titles/labes/... there is bunch of hardcoded texts in template definitions. Please try to find all of them and use i18n for them. |
| Comment by Jan Haderka [ 23/Feb/15 ] |
|
Don't see anywhere missing changes mentioned from first review. Maybe they are not pushed yet? |
| Comment by Antonín Juran [ 23/Feb/15 ] |
|
Wasn't pushed on remote branch. |
| Comment by Milan Divilek [ 02/Mar/15 ] |
|
Reopen: https://jenkins.magnolia-cms.com/job/int_migration-tests_5.2-to-5.3.x-branch/678/Diff_Reports/ |
| Comment by Antonín Juran [ 02/Mar/15 ] |
|
Fixed on branch |
| Comment by Milan Divilek [ 02/Mar/15 ] |
|
Reopen: Same for example for "areas.components.linkList.description" which was change to "shop.templates.components.teasers.shopProductTeaser.areas.linkList.description" |
| Comment by Roman Kovařík [ 17/Apr/15 ] |
|
Missing i18n: And you can also fix another issue:
2015-04-17 13:01:10,389 ERROR info.magnolia.jcr.wrapper.ExtendingNodeWrapper : Can't find referenced node for value: node /modules/shop/templates/components/features/form/shopConfirmTerms
|
| Comment by Antonín Juran [ 19/Apr/15 ] |
|
Fixed on branch |
| Comment by Milan Divilek [ 23/Apr/15 ] |
|
Reopen: i18n key shoppingCarts.browser.actionbar.sections.multiple.label key has wrong value "Folder" Missing i18n for sampleShopShoppingCarts apps. For example: |
| Comment by Antonín Juran [ 24/Apr/15 ] |
|
Fixed on branch |