[MSHOP-154] Shopping carts are not displayed in All carts app Created: 19/May/14  Updated: 22/Apr/15  Resolved: 09/Feb/15

Status: Closed
Project: Magnolia Shop (closed)
Component/s: None
Affects Version/s: 2.0.1
Fix Version/s: 2.0.1, 2.1.1

Type: Bug Priority: Neutral
Reporter: Ruth Stocks Assignee: AntonĂ­n Juran
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows 7


Attachments: PNG File shopping-carts.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When you go through the checkout process on a page the shopping carts show up in the dedicated shopping carts app/s but not the Manage shops > All carts app. See attached screenshot.
Tested on magnolia-enterprise-5.2.4/magnolia-module-shop-2.0.1-SNAPSHOT (April 22)



 Comments   
Comment by Milan Divilek [ 06/Feb/15 ]

Reopen:
1.In update task "Setting name property of folderNodeType in shoppingCarts" you are using info.magnolia.module.delta.NodeExistsDelegateTask, but with path to property "/modules/shop/apps/shoppingCarts/subApps/browser/workbench/nodeTypes/folderNodeType/name". Path for check should be just "/modules/shop/apps/shoppingCarts/subApps/browser/workbench/nodeTypes/folderNodeType"

2.in info.magnolia.module.shop.setup.ShopModuleVersionHandlerTest#testShoppingCartsHaveFolderNodeTypeWithNamePropertyValueMgnlFolderAfterUpgrade

assertEquals(config.getNode("/modules/shop/apps/shoppingCarts/subApps/browser/workbench/nodeTypes/folderNodeType").getProperty("name").getString(), NodeTypes.Folder.NAME);
assertTrue(config.itemExists("/modules/shop/apps/shoppingCarts/subApps/browser/workbench/nodeTypes/folderNodeType/name"));

you first get the property and after it you are checking if the property exists.

Please don't forget add update task to DeltaBuilder.update("2.1.1"... during integration into version 2.1.1.

Comment by Milan Divilek [ 06/Feb/15 ]

Reopen:

new PartialBootstrapTask("Setting folderNodeType in shoppingCarts", "Setting folderNodeType to mgnl:folder in shoppingCarts workbench.", "/mgnl-bootstrap/shop/config.modules.shop.apps.xml", "/apps/shoppingCarts/subApps/browser/workbench/")))

you don't want bootstrap whole workbench ("/apps/shoppingCarts/subApps/browser/workbench/") node again, but only "/apps/shoppingCarts/subApps/browser/workbench/nodeTypes".

Integration:
port from 2.0.x to 2.1.x is not straightforward. In 2.1.x content connectors are used.

Comment by AntonĂ­n Juran [ 09/Feb/15 ]

ver. 2.0.1 fixed on branch MSHOP-154
ver. 2.1.1 fixed on branch MSHOP-154_2

Comment by Milan Divilek [ 22/Apr/15 ]

Git commit has wrong ticket number: https://git.magnolia-cms.com/gitweb/?p=forge/shop.git;a=commit;h=df8aef59e1974204db8707c7d3b82450a42978c7

Generated at Mon Feb 12 07:09:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.