[MSHOP-179] Cant open detail page in my shop products app Created: 14/May/15  Updated: 22/Jun/15  Resolved: 22/Jun/15

Status: Resolved
Project: Magnolia Shop (closed)
Component/s: None
Affects Version/s: 2.2
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Teresa Miyar Assignee: Viet Nguyen
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.5d
Original Estimate: 0.5d

Attachments: PNG File MSHOP-179_fixed.png     PNG File Screen Shot 2015-05-14 at 14.26.13.png     PNG File Screen Shot 2015-05-14 at 14.26.26.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

I've created my own shop with the manage shops app, when I want to create or modify a product from my shop product app it gives me an error see screen shoots. To create products I have to go to all products app



 Comments   
Comment by Viet Nguyen [ 25/May/15 ]
  • When extending 'shop' module you need to specify your contentConnector rootPath and application name for editProduct action. Just follow 'sampleShopProducts' which is provided sample of Shop module - Magnolia. The fix is included in attached image. In your case because you did not provide these information, the application look for wrong location and it broke the app. The error report need to be improve also to inform user in this case.
Comment by Viet Nguyen [ 25/May/15 ]

info.magnolia.ui.contentapp.detail.DetailEditorPresenter in magnolia-ui-contentapp-5.3.8 line 117-118 need to improve:

Object parentId = contentConnector.getItemIdByUrlFragment(StringUtils.substringBeforeLast(nodePath, "/"));
itemId = ((SupportsCreation) contentConnector).getNewItemId(parentId, editorDefinition.getNodeType().getName());

in case user enter wrong appName in "subApps/browser/actions/editProduct@appName" NPE throws because "parentId" is null!
--> Fix: check null and notify user about wrong configuration.

Comment by Jan Haderka [ 16/Jun/15 ]

There is no commit related to this ticket visible in jira. Only commits are visible are those related to cma project. Can you pls provide link to the commits resolving this issue?
Thx.

Comment by Viet Nguyen [ 22/Jun/15 ]

@Jan: this is not an issue so we did not do anything other than investigate the reported symptom, try to find the root cause and suggest what's wrong with customer config and how to fix it (attached image). Sorry for a little bit confuse, I changed the resolution of this ticket to "Not an issue" --> hope this help! The improvement for the core ui has been fixed by maintenance team.

Generated at Mon Feb 12 07:10:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.