[MSHOP-180] Suppliers dialog does not have a mandatory field Created: 14/May/15 Updated: 03/Jul/19 Resolved: 03/Jul/19 |
|
| Status: | Closed |
| Project: | Magnolia Shop (closed) |
| Component/s: | None |
| Affects Version/s: | 2.2 |
| Fix Version/s: | 2.2.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Teresa Miyar | Assignee: | Viet Nguyen |
| Resolution: | Outdated | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 0.5d | ||
| Original Estimate: | 0.5d | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
If you do not enter the company name, you don't get anything in the suppliers selector in the product dialog. The company name is in the second tab of the suppliers dialog easy to miss. |
| Comments |
| Comment by Viet Nguyen [ 26/May/15 ] |
info.magnolia.module.shop.app.field.factory.ProductSupplierSelectFieldFactory - line 86:
fieldDefinition.setLabel(supplier.getName() + '(' + PropertyUtil.getString(supplier, "company", "N/A") + "@" + PropertyUtil.getString(supplier, "city", "N/A") + ')');
|
| Comment by Viet Nguyen [ 26/May/15 ] |
|
Also set this to true to force input company name: /modules/shop/dialogs/createSupplier/form/tabs/address/fields/company@required="true" |
| Comment by Jan Haderka [ 16/Jun/15 ] |
|