[MSHOP-182] Product categories do not show in the product detail dialog if the page does not have a title Created: 14/May/15  Updated: 03/Jul/19  Resolved: 03/Jul/19

Status: Closed
Project: Magnolia Shop (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 2.2.1

Type: Bug Priority: Neutral
Reporter: Teresa Miyar Assignee: Viet Nguyen
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.75d
Original Estimate: 0.25d

Attachments: PNG File Screen Shot 2015-05-14 at 14.51.09.png     PNG File Screen Shot 2015-05-14 at 14.52.06.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

It shows an empty checkbox



 Comments   
Comment by Viet Nguyen [ 26/May/15 ]
  • Fix: so we will use node name in case of empty page title by modify this:
    info.magnolia.module.shop.app.field.factory.ProductCategoriesFieldFactory - line 81
    old:
    field.setLabel(PropertyUtil.getString(category, "title"));
    new:
    field.setLabel(PropertyUtil.getString(category, "title", category.getName()));
Comment by Jan Haderka [ 16/Jun/15 ]
  • you can't rewrite version history. Version 2.2 was already released. All the changes need to go on new unreleased version - 2.2.1
  • since this is a regression, there needs to be test for the problem
  • your commit leaks changes from other issue (setting company field as mandatory). Please take care to keep changes separate
  • please do not commit fixes on master, but on separate branch, one per issue to allow for squashing of commits after review before merging to master
Generated at Mon Feb 12 07:10:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.