[MSHOP-36] Product detail links can contain illegal characters Created: 21/Sep/12  Updated: 19/Mar/13  Resolved: 22/Sep/12

Status: Closed
Project: Magnolia Shop (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.7

Type: Bug Priority: Major
Reporter: Will Scheidegger Assignee: Will Scheidegger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0.5d
Time Spent: Not Specified
Original Estimate: 0.5d

Issue Links:
Cloners
is cloned by MSHOP-45 Product titles and names (IDs) cause ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

When the detail page link is created, the product title is used for better search results in Google. Unfortunately depending on your product title the url may then contain illegal characters since only spaces are swapped for dashes. If your title contains a "." or even a "/" the link will not work.

Possible solutions:
1. url-encode the whole title => might make it hard to read
2. replace more characters which might cause trouble (at least "." and "/" - others?)



 Comments   
Comment by Will Scheidegger [ 22/Sep/12 ]

The ShopLinkUtil replaces now most of the common special characters... and URL-encodes the rest.

Generated at Mon Feb 12 07:08:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.