[MSHOP-45] Product titles and names (IDs) cause detail page link to fail Created: 18/Oct/12 Updated: 21/Jul/15 Resolved: 18/Oct/12 |
|
| Status: | Closed |
| Project: | Magnolia Shop (closed) |
| Component/s: | None |
| Affects Version/s: | 1.0, 1.0.1, 1.0.7, 1.1 |
| Fix Version/s: | 1.0.8 |
| Type: | Bug | Priority: | Major |
| Reporter: | Will Scheidegger | Assignee: | Will Scheidegger |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0.25d | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | 0.25d | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Description |
|
Although some improvements were added in 1.0.7 some special characters in the product title still were still able to break the link to product detail pages. In addition the shop admins are required to use "safe" characters for the product id. |
| Comments |
| Comment by Will Scheidegger [ 18/Oct/12 ] |
|
Using Path.getValidatedLabel() for title and name. This leaves the Umlaute (and such) in the strings but removes all troublemakers it seems. Resulting URLs work - tested in Safari, Firefox and IE 9 |