[MSHOP-48] Order address attributes are not being respected by the SaveAndConfirmFormProcessor Created: 12/Nov/12  Updated: 17/Jul/15  Resolved: 17/Jul/15

Status: Resolved
Project: Magnolia Shop (closed)
Component/s: None
Affects Version/s: 1.0.7, 1.1
Fix Version/s: 2.3.0

Type: New Feature Priority: Neutral
Reporter: Will Scheidegger Assignee: Will Scheidegger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 1h
Time Spent: Not Specified
Original Estimate: 1h

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

The DefaultShoppingCartImpl supports three types of addresses:

  • billing
  • shipping
  • and order
    The SaveAndConfirmFormProcessor however only fills in the billing and shipping attributes from the form into the shopping cart bean. On top of that, the ocm bean configuration does not handle these attributes either. Both should be fixed in 1.0.8 but needs to be incorporated into the 1.1 release as well.


 Comments   
Comment by Jaroslav Simak [ 04/Oct/13 ]

Needs to be verified if its still an issue.

Comment by Will Scheidegger [ 04/Oct/13 ]

The whole SaveAndConfirmFormProcessor.internalProcess() method is "broken by design" anyway (I guess this was my fault). It is totally inflexible. You can easily switch your shopping cart implementation in the shop configuration, but this won't do you any good as long as you don't adapt the form processor as well.

I did some tests with using bean utils to move the data from the form to the shopping cart. I think this would be the right way to go. This should also solve the order address problem.

Comment by Will Scheidegger [ 17/Jul/15 ]

OK, so for safety reasons we should NOT use bean utils because this would make it quite easy for someone to set the cart discount to 100% or the payment state to payed. We'll stick to the boiler plate code, but will move it to the cart itself. So when you call "updateCartData(Map newCartData)" it is in the cart's responsibility to fill in the data properly.

Comment by Will Scheidegger [ 17/Jul/15 ]

updating of cart values is now handled by the cart itself instead of the SaveAndConfirmFormProcessor. "termsAccepted" is handled.

Generated at Mon Feb 12 07:08:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.