[MSHOP-63] Installation of Shop 1.1.1 on Magnolia CE 4.5.7 fails with PathNotFoundException: modules/data/commands/data/activate/startFlow Created: 22/Feb/13  Updated: 08/Jul/13  Resolved: 27/Jun/13

Status: Closed
Project: Magnolia Shop (closed)
Component/s: None
Affects Version/s: 1.1.1
Fix Version/s: 1.1.3

Type: Bug Priority: Major
Reporter: Will Scheidegger Assignee: Will Scheidegger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   
  • Took a new 4.5.7 CE
  • Installed and tested it (demo project)
  • Added the shop jars
  • Installation failed with:

2013-02-22 18:20:17,207 ERROR info.magnolia.module.InstallContextImpl : > Could not install or update shop module. Task 'Fix activation Product prices and categories' failed. (PathNotFoundException: modules/data/commands/data/activate/startFlow)
info.magnolia.module.delta.TaskExecutionException: Could not execute task: Path not found: modules/data/commands/data/activate/startFlow
at info.magnolia.module.delta.AbstractRepositoryTask.execute(AbstractRepositoryTask.java:62)
at info.magnolia.module.ModuleManagerImpl.applyDeltas(ModuleManagerImpl.java:499)
at info.magnolia.module.ModuleManagerImpl.installOrUpdateModule(ModuleManagerImpl.java:481)
at info.magnolia.module.ModuleManagerImpl$1.doExec(ModuleManagerImpl.java:270)
at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:443)
at info.magnolia.context.MgnlContext$VoidOp.exec(MgnlContext.java:440)
at info.magnolia.context.MgnlContext.doInSystemContext(MgnlContext.java:403)
at info.magnolia.module.ModuleManagerImpl.performInstallOrUpdate(ModuleManagerImpl.java:264)
at info.magnolia.module.ui.ModuleManagerWebUI$2.run(ModuleManagerWebUI.java:127)
at java.lang.Thread.run(Thread.java:680)
Caused by: javax.jcr.PathNotFoundException: modules/data/commands/data/activate/startFlow
at org.apache.jackrabbit.core.NodeImpl$8.perform(NodeImpl.java:2136)
at org.apache.jackrabbit.core.NodeImpl$8.perform(NodeImpl.java:2130)
at org.apache.jackrabbit.core.session.SessionState.perform(SessionState.java:216)
at org.apache.jackrabbit.core.ItemImpl.perform(ItemImpl.java:91)
at org.apache.jackrabbit.core.NodeImpl.getNode(NodeImpl.java:2130)
at info.magnolia.jcr.wrapper.DelegateNodeWrapper.getNode(DelegateNodeWrapper.java:194)
at info.magnolia.jcr.wrapper.ChildWrappingNodeWrapper.getNode(ChildWrappingNodeWrapper.java:62)
at info.magnolia.cms.core.DefaultContent.<init>(DefaultContent.java:114)
at info.magnolia.cms.core.DefaultHierarchyManager.wrapAsContent(DefaultHierarchyManager.java:233)
at info.magnolia.cms.core.DefaultHierarchyManager.getContent(DefaultHierarchyManager.java:225)
at info.magnolia.module.delta.SetPropertyTask.doExecute(SetPropertyTask.java:85)
at info.magnolia.module.delta.AbstractRepositoryTask.execute(AbstractRepositoryTask.java:60)
... 9 more



 Comments   
Comment by Will Scheidegger [ 22/Feb/13 ]

O.k., this issue is a bit of a moving target and I guess I should not be managing it tonight as I'm clearly not "at my best". But the upgrade tasks which are supposed to fix the activation problems cannot stay the way they are right now. They would overwrite any configuration made by anyone else having the same problem. And they only work on EE as CE does not even have the startFlow command.

Can this be resolved better by a custom tree configuration?

Comment by Will Scheidegger [ 30/Mar/13 ]

Just tried to install Shop 1.1.1 on a fresh Magnolia CE 4.5.8. The same error still occurs:

Could not install or update shop module. Task 'Fix activation Product prices and categories' failed. (PathNotFoundException: modules/data/commands/data/activate/startFlow)

Comment by Will Scheidegger [ 30/Mar/13 ]

I think I found the problem. The "NodeExistsDelegateTask" was added to the 1.1.1 delta, making sure that the SetPropertyTask only was executed when the node exists. However in case of a clean install, this is not used. Rather the extraInstallTasks are being used... and there the SetPropertyTasks were not wrapped in a NodeExistsDelegateTask.

This is fixed now by http://git.magnolia-cms.com/gitweb/?p=forge/shop.git;a=commit;h=ff9ccf88d7240d51c7c6389d5f0eb2647e54c3de

One more thing: In the extraInstallTask the node type properties are set for the activation as well as the deactivation command. In the 1.1.1 delta this is only done for the activation command. Could it be that this was forgotten?

Comment by Teresa Miyar [ 02/Apr/13 ]

It was forgotten

Comment by Will Scheidegger [ 16/May/13 ]

I uncommented all the stuff in the version handler that caused troubles on CE. One should have an other look at it though because I have not tested it on EE yet – and I think activation of products with subnodes like prices, options... might fail? Sämi told me to assign this to you, Jan.

Generated at Mon Feb 12 07:08:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.