[MSITEMESH-13] Don't create a new connection for fragment requests Created: 11/Dec/14  Updated: 16/Dec/16  Resolved: 30/Oct/16

Status: Closed
Project: SiteMesh
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1

Type: Improvement Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.25d
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLEE-460 Adjust integration tests to changes i... Closed
is causing MSITEMESH-49 Remove workarounds for MAGNOLIA-6821 ... Closed
dependency
depends upon MGNLPN-341 VariantResolverFilter is not triggere... Closed
depends upon MGNLADVCACHE-77 FragmentInjectionListener improvements Closed
depends upon MGNLCACHE-147 Cache filter is not triggered for for... Closed
supersession
supersedes MSITEMESH-43 Invalid security token if fragment is... Closed
supersedes MGNLCACHE-145 Provide a local scoped component whic... Closed
supersedes MSITEMESH-47 DPC: Don't request URI if fragment is... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Documentation update required:
Yes
Sprint: Kromeriz 68
Story Points: 5

 Description   

Currently we create a new connection for each fragment request.

  1. Make use of info.magnolia.sitemesh.webapp.MagnoliaWebAppContext#decorate
    -It looks like the connection is closed by tomcat after the first forward, making other fragments on the page to fail (reproducible with the integration test crawler).-
    --Use WebContext.include() instead.-
  2. Make sure the cache, variant resolver and model execution filters (all once per request filters) are triggered despite the fact that the forward is still the same request as original target.


 Comments   
Comment by Roman Kovařík [ 31/Oct/16 ]

For release notes:

  • Sitemesh doesn't create a new URL connection for fragment requests, request forward is used instead.
    For documentation:
  • remove baseURL property docu...is not used anymore (M5.5 only)
Generated at Mon Feb 12 10:56:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.