[MSITEMESH-45] Sample MetaNavigationCacheKeyGenerator is not variant aware Created: 01/Sep/16  Updated: 16/Sep/16  Resolved: 15/Sep/16

Status: Closed
Project: SiteMesh
Component/s: None
Affects Version/s: 1.0.3
Fix Version/s: 1.0.4

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Sprint: Kromeriz 61
Story Points: 3

 Description   

info.magnolia.sitemesh.samples.MetaNavigationCacheKeyGenerator is not variant aware, resulting into:

[WARNING] [talledLocalContainer] 2016-09-01 08:32:37.811:WARN:oejs.ServletHandler:qtp377932536-11: /magnoliaTestPublic/demo-project/variants/variant-0~mgnlArea=branding,metaNavigation~
[INFO] [talledLocalContainer] java.lang.IllegalStateException: Already replayed !
[INFO] [talledLocalContainer] 	at info.magnolia.module.cache.entry.SingleReplayCacheEntryWrapper.replay(SingleReplayCacheEntryWrapper.java:78)
[INFO] [talledLocalContainer] 	at info.magnolia.module.cache.executor.UseCache.processCachedEntry(UseCache.java:84)
[INFO] [talledLocalContainer] 	at info.magnolia.module.cache.executor.UseCache.processCacheRequest(UseCache.java:62)
[INFO] [talledLocalContainer] 	at info.magnolia.module.cache.executor.CompositeExecutor.processCacheRequest(CompositeExecutor.java:67)
[INFO] [talledLocalContainer] 	at info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:174)
[INFO] [talledLocalContainer] 	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:59)

Reproducible with info.magnolia.eeintegrationtests.cache.VariantCachingTest#pageVariantCaching



 Comments   
Comment by Roman Kovařík [ 13/Sep/16 ]

Result of the investigation:
Cache key generator configured for a fragment overrides the default personalised cache key generator. A custom generator has to extend personalised cache key generator as well.

Generated at Mon Feb 12 10:57:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.