Use SiteMesh as module for snippet injection
(MSITEMESH-8)
|
|
| Status: | Closed |
| Project: | SiteMesh |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0 |
| Type: | Sub-task | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Date of First Response: | |||||||||
| Comments |
| Comment by Jan Haderka [ 08/Dec/14 ] |
|
| Comment by Roman Kovařík [ 08/Dec/14 ] |
|
From current code: //cache saves items under original browser URL which is the same, we can't cache it when dispatching otherwise we'd rewrite original cache item! //TODO use URLConnection instead to support caching responseBuffer.setHeader("Cache-Control", "no-cache"); When we'll know that someone really use these SiteMesh decorators we can implement that so those will be cached. |
| Comment by Jan Haderka [ 08/Dec/14 ] |
|
Should the shouldBypass() method be really private or should we allow anyone extending the filter to change it? |
| Comment by Roman Kovařík [ 08/Dec/14 ] |
|
Since a recursive SiteMesh processing could lead to an unpredicted behaviour, I'd would keep it private. |