Use SiteMesh as module for snippet injection (MSITEMESH-8)

[MSITEMESH-9] Add rendering listener for automatic snippet tags inclusion Created: 26/Nov/14  Updated: 15/Dec/14  Resolved: 08/Dec/14

Status: Closed
Project: SiteMesh
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Sub-task Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-6000 Implement a rendering listener which ... Closed
Template:
Date of First Response:

 Comments   
Comment by Jan Haderka [ 08/Dec/14 ]
  • MagnoliaWebAppContext there's TODO left in the class that is not really clear. Care to explain in more details what is missing?
Comment by Roman Kovařík [ 08/Dec/14 ]

From current code:

//cache saves items under original browser URL which is the same, we can't cache it when dispatching otherwise we'd rewrite original cache item!
//TODO use URLConnection instead to support caching
responseBuffer.setHeader("Cache-Control", "no-cache");

When we'll know that someone really use these SiteMesh decorators we can implement that so those will be cached.

Comment by Jan Haderka [ 08/Dec/14 ]

Should the shouldBypass() method be really private or should we allow anyone extending the filter to change it?

Comment by Roman Kovařík [ 08/Dec/14 ]

Since a recursive SiteMesh processing could lead to an unpredicted behaviour, I'd would keep it private.

Generated at Mon Feb 12 10:56:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.