[MTE-114] Module is not compatible with site module shipped with M6.1 and M6.2 Created: 07/Apr/20  Updated: 28/May/20  Resolved: 24/Apr/20

Status: Closed
Project: Magnolia Templating Essentials
Component/s: None
Affects Version/s: 1.2.3
Fix Version/s: 1.4, 1.5

Type: Bug Priority: Neutral
Reporter: Federico Grilli Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: regression
Remaining Estimate: 0d
Time Spent: 44m
Original Estimate: Not Specified
Environment:

Magnolia 6.2.1-SNAPSHOT, Site 1.3


Issue Links:
dependency
depends upon MAGNOLIA-7667 Remove Content API from File Closed
is depended upon by MGNLUI-5798 Make link field extend select field a... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Sprint: UI Framework 22

 Description   

To reproduce

  • Pages app -> /travel
  • images are broken

Trying to request one of the images directly throws the error below. E.g.
http://localhost:8080/magnoliaPublic/.imaging/mte/travel-demo-theme/1600x1200/dam/tours/flickr-bike-pierce-martin-9812237694_8112ca89ea_o.jpg/jcr:content/flickr-bike-pierce-martin-9812237694_8112ca89ea_o.jpg

java.lang.NoSuchMethodError: info.magnolia.module.site.SiteModule.getTheme(Ljava/lang/String;)Linfo/magnolia/module/site/theme/Theme;
	info.magnolia.templating.imaging.parameters.ThemeAwareParameter.getImageVariation(ThemeAwareParameter.java:67)
	info.magnolia.templating.imaging.ThemeAwareImageGenerator.resolveImageVariation(ThemeAwareImageGenerator.java:94)
	info.magnolia.templating.imaging.ThemeAwareImageGenerator.generate(ThemeAwareImageGenerator.java:67)
	info.magnolia.imaging.DefaultImageStreamer.serveImage(DefaultImageStreamer.java:61)
	info.magnolia.imaging.caching.CachingImageStreamer.generateAndStore(CachingImageStreamer.java:226)

This is related to deprecation removal, see https://git.magnolia-cms.com/projects/MODULES/repos/site/commits/bdbb2e0

/**
 * @deprecated since 1.0.6 - use {@link ThemeRegistry} IoC instead.
 */
@Deprecated
public Theme getTheme(String name)


 Comments   
Comment by Federico Grilli [ 28/May/20 ]

While doing pre-staging QA for Magnolia 6.1.6 I realized the same issue affected it.
Created a proper 1.4 branch out of 1.5 compatible with M6.1 with this fix included.

Generated at Mon Feb 12 07:41:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.