[MTE-137] Configuring an image operation in a variation Created: 03/Feb/22  Updated: 13/Jul/22  Resolved: 15/Mar/22

Status: Closed
Project: Magnolia Templating Essentials
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0.2

Type: Bug Priority: Neutral
Reporter: Richard Gange Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Support
Sprint: DevX 5
Story Points: 5
Team: DeveloperX

 Description   

The section Configuring an image operation in a variation is unclear. Currently it's showing the example as a JCR configuration. This configuration was moved into YAML some time ago. When trying to convert it to YAML it doesn't seem to be working. The current JCR example is lacking in sense because why would this configuration exist as a subnode of variations.

I am trying to sort that out now. I think it should look something like this instead but that still doesn't work:

imaging:
  class: info.magnolia.templating.imaging.VariationAwareImagingSupport
  variations:
    "1600x1200":
      class: info.magnolia.templating.imaging.variation.ImageOperationProvidingVariation
      imageOperation:
        class: info.magnolia.imaging.operations.ImageOperationChain
        outputFormat:
          formatName: png
          quality: 20
        parameterProviderFactory:
          class: info.magnolia.imaging.parameters.BinaryNodeParameterProviderFactory
        operations:
          load:
            class: info.magnolia.imaging.operations.load.FromBinaryNode
          resize:
            class: info.magnolia.imaging.operations.cropresize.BoundedResize
            maxWidth: 1600
            maxHeight: 1200

Output format is not applied.

Notes
I also tired by configuring a generator but that threw an exception.

WARN  info.magnolia.imaging.ImagingServlet 04.02.2022 13:40:18 -- Because of incorrect arguments the image couldn't be found
info.magnolia.imaging.ImagingRuntimeException: Can't load source for identifier '1600x1200' from workspace 'travel-demo-theme'
	at info.magnolia.imaging.parameters.AbstractJcrWorkspaceAndIdentifierParameterProviderFactory.newParameterProviderFor(AbstractJcrWorkspaceAndIdentifierParameterProviderFactory.java:84) ~[magnolia-imaging-3.5.2.jar:?]

Generated at Mon Feb 12 07:41:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.