[MTE-25] Adapt main page template to work with Marketing Tags Manager Created: 07/May/15 Updated: 01/Jul/15 Resolved: 20/May/15 |
|
| Status: | Closed |
| Project: | Magnolia Templating Essentials |
| Component/s: | None |
| Affects Version/s: | 0.5 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Christopher Zimmermann |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Marketing Tags requires three areas to be present in the page template for it to be able to insert scripts. The areas should reference (via the site prototype) a placeholder templateScript & modelClass so that they can safely be replaced by the MarketingTags module. |
| Comments |
| Comment by Christopher Zimmermann [ 12/May/15 ] |
|
updated main.ftl and site prototype to include the areas MarketingTags required. |
| Comment by Philip Mundt [ 15/May/15 ] |
|
I would disagree with the reasoning above: Just because marketing-tags-manager adds those areas why should we have to add them here? In other words, we're adding stuff to a CE module that is only useful when the respective EE module is installed (no dependencies involved either). This will be confusing for beginners. Adding placeholder classes that do nothing also doesn't fit the MTE approach of "less is more". I would add such a template to the marketing-tags module (so a developer can easily swap templates). For the purpose of the the demo, the demo-marketing-tags module should handle the delta. |
| Comment by Philip Mundt [ 15/May/15 ] |
|
Why is |
| Comment by Christopher Zimmermann [ 20/May/15 ] |
|
Agree with Philip's comments above mostly. We should find a better way for modules to interact with MTE components. |