[MTE-3] Navigation features Created: 13/Jan/15  Updated: 09/Feb/17  Resolved: 14/Oct/16

Status: Closed
Project: Magnolia Templating Essentials
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1

Type: Story Priority: Major
Reporter: Christopher Zimmermann Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 4d
Time Spent: Not Specified
Original Estimate: 4d

Attachments: PNG File Screen Shot 2016-10-10 at 16.09.52.png    
Issue Links:
Relates
relates to MTE-56 Sitemap component Closed
dependency
depends upon MTE-39 Concept for Navigation Closed
is depended upon by MGNLDEMO-111 Navigation in travel demo should be b... Closed
relation
is related to MTE-94 Improve javadoc in NavigationTemplati... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: LD: Fundamental features
Sprint: Kromeriz 65
Story Points: 13

 Description   

Finalize navigation POC so that when developing a new site I can create a centralised navigation based on pages and content pools

The Navigation delivered in MTE-39 is on POC level and currently not available in our code base.

The task for this issue is to finalize what was done in MTE-39, add tests and make it production ready + integrate it in the code base.



 Comments   
Comment by Christopher Zimmermann [ 16/Jul/15 ]

Reducing estimate as the concept is now a separate ticket.

Comment by Christopher Zimmermann [ 21/Jan/16 ]

We need some basic navigation assistance for developers - it does not need to be super flexible. Consider this a "Phase 1" navigation features. I suggest timeboxing to 8 story points in the interest of ensuring we get some navigation functionality - even if it is not sophisticated/flexible enough to use for the travel demo.

Comment by Christopher Zimmermann [ 13/Apr/16 ]

Please include me in review.

Comment by Tomáš Gregovský [ 07/Oct/16 ]

Tested Milan's work-in-progress version of navfn for bootstrap light module (part of now demo) and really like the way how it is made. Instead of doing full navigation rendering this navfn gives only tools frontenders can use to render any navigation they want. (regular, with content apps, deep, ...)

Here is a print screen of test implementation I did https://drive.google.com/open?id=0B23s2-CZM0HzMXh0UGpxdUNyMmM with hightlighted key features.

Also really like option to use it to generate links with selectors/parameters in any template (not only in nav). E.g. assign contactLink = navfn.linkWithSelector(contactsPage, item)

There is couple of points we had a long discussion about. Which I would like to just quickly clarify:

  • navfn.isNotHiddenInNav() - since we using 'hideInNav' property we agreed on have hide/hidden work in name of this method (we prefered it compare to !navfn.isHiddenInNav() or navfn.isVisibleInNav() )
  • navfn.link() and navfn.hasTemplate() - both are currently doable with cmsfn, but to be able to do complete navigation just with navfn and dont ppl struggle with remembering (looking to documentation) which method is available where we think is better to have them in navfn too.
Comment by Christopher Zimmermann [ 12/Oct/16 ]

Example of navigation where parents of the active page also have a special style. It would be good if the navigation system provided this - possibly with the css class "open", or "active-parent".

Comment by Evzen Fochr [ 14/Oct/16 ]

Migration diff

Generated at Mon Feb 12 07:40:30 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.