[MTE-49] More sophisticated main page template Created: 08/Oct/15 Updated: 26/Feb/16 Resolved: 08/Feb/16 |
|
| Status: | Closed |
| Project: | Magnolia Templating Essentials |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 0.9 |
| Type: | Story | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Christoph Meier |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0.5h | ||
| Time Spent: | 2d 0.5h | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Release notes required: |
Yes
|
||||||||||||
| Documentation update required: |
Yes
|
||||||||||||
| Date of First Response: | |||||||||||||
| Epic Link: | LD: components + pages | ||||||||||||
| Sprint: | Basel 30 | ||||||||||||
| Story Points: | 8 | ||||||||||||
| Description |
|
Do the following things
areas to add which (will may have its own area template):
dialog should be based on / be similar as /mte/dialogs/pages/pageProperties.yaml (actually moving this file to /mtk/dialogs/pages/basic.yaml) i18n should follow "best practices" since we already have ticket (see template definition class: Use info.magnolia.templating.definition.PageTemplateDefinition as soon as |
| Comments |
| Comment by Christoph Meier [ 01/Feb/16 ] |
|
Note that the one and only page template within whole "MTE" (incl. subreactors) currently is part of mte. I will move it to mtk. From the above mentioned components which should be included from the main page template "MTE" (both subreactors mte and mtk) does not provide htmlHeader, navigation, footer, main ... so ... basically none of these components are available. |
| Comment by Christopher Zimmermann [ 01/Feb/16 ] |
|
I would suggest handling the compoents mentioned in this ticket. I think it will be easier to manage - but dev team should make that decision. I recomment using the main.ftl, and standard.yaml (and the related configuration stored in JCR/prototype!) from the magnolia travel-demo module as a starting point for the page. Concerning navigation, I would include the area, but not a template, and specify no available components in the page definition. |
| Comment by Christopher Zimmermann [ 01/Feb/16 ] |
|
Recommend updating html page based on latest https://html5boilerplate.com/ |
| Comment by Christopher Zimmermann [ 01/Feb/16 ] |
|
Suggestion for page .ftl template based on html5boilerplate. I think we should include the main.css and normalize css as well. |
| Comment by Philip Mundt [ 01/Feb/16 ] |
|
To be determined: What should the name of that template be? MTE Page? |
| Comment by Christopher Zimmermann [ 01/Feb/16 ] |
|
For the name, how about basic, simple or standard? I think basic would be appropriate. |
| Comment by Philip Mundt [ 02/Feb/16 ] |
I vote against adding this file because
|
| Comment by Christopher Zimmermann [ 02/Feb/16 ] |
|
I think the standardComponents.yaml would be a decent pattern as a straightforward way to add and manage availability of a bunch of components. I would have recommended also including it in the columnLayout component. Project devs could use it include it in their own pages or components that have areas. This is more the point - and its not addressed by YAML's & and *. I agree that its fairly bogus for the footer - because it is too open - but I dont think its a bad default. It's less relevant with a JCR based site (prototype) - but once site is YAML based I still think its useful for the above reasons. But I like that standardComponents.yaml solution works out of the box without any site configuration. However, I dont mind if we skip the standardComponents.yaml idea for now if you or someone feels strongly about it. |
| Comment by Christopher Zimmermann [ 03/Feb/16 ] |
|
Agree to skip the standardComponents.yaml. |
| Comment by Christoph Meier [ 03/Feb/16 ] |
|
What is the expectation about the styling of this "basic" template, pmundt, czimmermann? |
| Comment by Christopher Zimmermann [ 03/Feb/16 ] |
|
Lets go with a) for now. It's closer to the goal. We can add something later if it is too unattractive. |