[MTE-74] Use i18n "best practices" in MTK Created: 02/Feb/16 Updated: 15/Apr/16 Resolved: 21/Mar/16 |
|
| Status: | Closed |
| Project: | Magnolia Templating Essentials |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 0.10 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 2d 5h 5m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Epic Link: | Introduction of new i18n | ||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Kromeriz 30, Kromeriz 36 | ||||||||||||||||||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
Do not set i18n-basename, label, description on dialogs and templates - instead make use of autogenerated keys and use bundles within i18n folder. Move keys from "old" bundles into i18n folder wherever possible. |
| Comments |
| Comment by Christopher Zimmermann [ 03/Feb/16 ] |
|
I am really looking forwards to this! |
| Comment by Christopher Zimmermann [ 04/Feb/16 ] |
|
Please include me in review. |
| Comment by Roman Kovařík [ 05/Feb/16 ] |
|
czimmermann You might want to wait for |
| Comment by Evzen Fochr [ 05/Feb/16 ] |
|
I think release notes will be required for this ticket. We are changing i18n keys, so if somebody use them in their yaml ... |
| Comment by Christopher Zimmermann [ 08/Feb/16 ] |
|
Im out of work for at least a week - so you can ignore my review request. |
| Comment by Roman Kovařík [ 08/Feb/16 ] |
|
For release notes:
|
| Comment by Milan Divilek [ 08/Feb/16 ] |
|
This ticket breaks labels/descriptions in travel-demo, solr module ... This is caused by usage of new i18n mechanism and autogenerated keys. This will be fixed in follow up tickets |
| Comment by Christopher Zimmermann [ 18/Feb/16 ] |
|
Reopening because all files associated with a light module must be in the main/src/resources/[module-name] directory. In this case, the i18n files should be in a directory within "mtk". |
| Comment by Christopher Zimmermann [ 22/Feb/16 ] |
|
Also the keys for mtk translations should not specify the modulename - this is because it must be easy for people to base their own templates on the mtk templates, for example by copying them into their own module. So we should use keys without the modulename - for example: |
| Comment by Christopher Zimmermann [ 22/Feb/16 ] |
|
Keys for textimage tabImage should be usable in other components, like the image component. use this pattern: Then we can remove the redundant keys introduced for the image component |