[MTOOL-2] Include decorations info in converted definitions Created: 16/Feb/21  Updated: 19/Feb/21  Resolved: 19/Feb/21

Status: Closed
Project: Migration Tool
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Edwin Guilbert Assignee: Edwin Guilbert
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

When a definition is converted, it takes into account all the includes and decorations processed in the "final" def in the registry.

Since the definition bean already contains the decoration info (the module and yaml applying a decoration), this could be added to the converted definition as a comment, just as the previous def is included in the converted YAML file.



 Comments   
Comment by Edwin Guilbert [ 18/Feb/21 ]

Sample of the result:

label: Edwin Dialog Decorated 2
width: medium
form:
  name: Edwin Dialog Decorated 2
  properties:
  - name: doubleText
    label: Edwin Title2
    type: java.lang.Double
    converterClass: com.vaadin.data.converter.StringToDoubleConverter
    $type: textField
# form:
#   label: Edwin Dialog
#   tabs:
#     - name: tabMain
#       label: Edwin Content
#       fields:
#         - name: doubleText
#           fieldType: text
#           label: Edwin Title2
#           type: Double
# actions:
#   commit:
#     label: save changes
#     class: info.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition
#   cancel:
#     label: cancel
#     class: info.magnolia.ui.admincentral.dialog.action.CancelDialogActionDefinition
#
#
#
# Decorations found:
# /dummy-connector/decorations/angularEndpoints-light-module/dialogs/components/edwinDouble.yaml/
# /demo-fixes/decorations/angularEndpoints-light-module/dialogs/components/edwinDouble.yaml/
Generated at Mon Feb 12 10:19:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.