[MULTISITE-133] New MultiSiteRegistry doesn't limit number of sites according to allowed sites by the license Created: 30/Jun/22  Updated: 10/Jan/24  Resolved: 20/Dec/23

Status: Closed
Project: Magnolia Multisite Module
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0.0

Type: Task Priority: Critical
Reporter: Milan Divilek Assignee: Quach Hao Thien
Resolution: Fixed Votes: 0
Labels: dx-core-6.3
Remaining Estimate: Not Specified
Time Spent: 9.5d
Original Estimate: Not Specified

Attachments: Java Source File SiteCountValidator.java    
Issue Links:
Relates
relates to MGNLSITE-105 Site definition registry Closed
relates to MULTISITE-122 As a developer, i want to be able to ... Closed
relates to MGNLREST-434 Change rest endpoint in Resource app ... Selected
dependency
depends upon MGNLSITE-207 Filter out all sites that are exceed ... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: 6.3 Consolidation
Team: DeveloperX
Work Started:
Approved:
Yes

 Description   

MGNLSITE-105 and MULTISITE-122 brings new SiteRegistry, unfortunately they are not limiting number of allowed sites configured in the license.

Developer notes:
While implementing the new registry, limitation for number of registered sites was removed. This check was previously done in MultiSiteRegistry#register and MultiSiteRegistry #unregisterAndRegister methods, but these are deprecated and not used with new ConfigurationSource mechanism. Registry doesn't hold the map of registered definition, but delegates into ConfigurationSource(every source holds own RegistryMap), so during the registration it is not possible to know how many definitions are registered by the other ConfigurationSources.
I also tried to implement SiteCountValdiator and add it via info.magnolia.config.registry.AbstractRegistry#addValidator, but that marked all definitions as problematic, but still registered them.


Generated at Mon Feb 12 06:06:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.