[MULTISITE-180] Default port is added for https links Created: 28/Oct/23  Updated: 10/Jan/24  Resolved: 03/Nov/23

Status: Closed
Project: Magnolia Multisite Module
Component/s: None
Affects Version/s: 2.1.2
Fix Version/s: 2.1.3, 3.0.0

Type: Bug Priority: Neutral
Reporter: Philipp Gaschuetz Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Problem/Incident
causality
is causing MULTISITE-186 Multisite DomainNamePathTransformer c... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MULTISITE-181 Review Sub-task Completed Jaroslav Simak  
MULTISITE-182 Implementation Sub-task Completed  
MULTISITE-183 PiQA Sub-task Completed Jaroslav Simak  
MULTISITE-184 QA Sub-task Completed Chuong Doan Huy  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: Support
Sprint: DevX 50
Team: DeveloperX
Work Started:

 Description   

A pull request for this issue has been created at https://git.magnolia-cms.com/projects/ENTERPRISE/repos/multisite/pull-requests/79/overview

 

info.magnolia.multisite.DomainNamePathTransformer is used to create fully qualified links. The current implementation unnecessarily appends the default port number (443) for https links

Steps to reproduce

  1. create a site with protocol == https and port == 443
  2. generate a link using info.magnolia.multisite.DomainNamePathTransformer

Expected results

it should return i.e. https://example.com

Actual results

returns i.e. https://example.com:443

Workaround

n/a

Development notes

The current implementation makes erroneous assumptions. Tests have been added.


Generated at Mon Feb 12 06:07:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.