[MULTISITE-26] stkForum template are not copied to MultiSite causing migration issues Created: 24/Jul/14  Updated: 29/Oct/15  Resolved: 30/Jul/14

Status: Closed
Project: Magnolia Multisite Module
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.6, 1.1.1

Type: Bug Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-5841 Updated instances behave as freshly i... Closed
relates to MAGNOLIA-5842 Updated instances behave as freshly i... Closed
dependency
depends upon MAGNOLIA-5858 Add delegate task only executing when... Closed
is depended upon by MULTISITE-25 MultiSite doesn't get TagsManager are... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Migration (4.5 to 5.2.x)

 Description   

stkForum template won't be migrated to MultiSite. This causes migration issues.



 Comments   
Comment by Philip Mundt [ 25/Jul/14 ]

stkForum shouldn't be copied to ETK, but rather MultiSite should take care of it.

Comment by Philip Mundt [ 30/Jul/14 ]

Moving task into magnolia_main.

Comment by Christopher Zimmermann [ 30/Jul/14 ]

Code looks good.

  • The name 'MultiConditionalDelegateTask' could be improved, its more about if paths exist. How about 'PathsExistConditionalDelegateTask'?
  • This task would be generally useful, I think it would be good to add it to the info.magnolia.module.delta package, if Platform team agrees.

If it is moved to the the info.magnolia.module.delta package:

  • I would add a parameter to the constructor for which workspace the checks are in.
  • I would also add a constructor which takes an additional ifFalse Task argument, where developer can specify task to run if the conditions evaluate to false.
Comment by Philip Mundt [ 30/Jul/14 ]
  • Task was moved to magnolia_main
  • Dependency to core was updated
Comment by Philip Mundt [ 30/Jul/14 ]

QA would include delta-check in:

Generated at Mon Feb 12 06:05:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.