[MULTISITE-30] Issue a warning if a site definition doesn't specify a defaultLocale Created: 24/Sep/14  Updated: 06/Oct/14  Resolved: 06/Oct/14

Status: Closed
Project: Magnolia Multisite Module
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1.2

Type: New Feature Priority: Neutral
Reporter: Evzen Fochr Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLUI-3128 FormBuilder: defaultLocale in dialogs... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

In MGNLUI-3128 the wrong usage of the fallbackLocale to add a suffix to i18nizable properties (in DefaultI18NAuthoringSupport.i18nize(...)) was fixed. It now uses the defaultLocale instead.

Solution/todo

It is important to check the site definitions and whether they have set a defaultLocale or inherit it from an extended site.

The dependency to UI also should be increased.



 Comments   
Comment by Mikaël Geljić [ 26/Sep/14 ]
  • Add a WarningTask to version handler, to check and warn if a site configuration doesn't have a default locale.
Comment by Mikaël Geljić [ 06/Oct/14 ]

Ran into a corner-case:

  • Having default site with defaultLocale set
  • Having a site definition extending it, using extends: override on the i18n subnode, and not setting any defaultLocale.

Checking task doesn't consider that site-definition correct, but it goes on to check its parent (default), which itself is correct. So it doesn't issue the warning.

Generated at Mon Feb 12 06:05:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.