[MULTISITE-43] Create site aware version of RegExpVirtualURIMapping Created: 28/May/15 Updated: 02/Jun/15 Resolved: 01/Jun/15 |
|
| Status: | Closed |
| Project: | Magnolia Multisite Module |
| Component/s: | None |
| Affects Version/s: | 1.2 |
| Fix Version/s: | 1.2 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
RegexpVirtualURIMapping is a useful VirtualURImapping but is not site aware. It would be useful to be able to target a mapping to only apply to a specific site. This would allow each site to map a specific url pattern (such as that created by RepositoryToUri mapping) to a different actual page. In fact this is the usecase which drives the creation of this mapping: |
| Comments |
| Comment by Philip Mundt [ 29/May/15 ] |
|
info.magnolia.multisite.MultiSiteRegexpVirtualURIMapping:
pom.xml:
info.magnolia.multisite.MultiSiteRegexpVirtualURIMappingTest:
|
| Comment by Philip Mundt [ 01/Jun/15 ] |
|
Parameter of constructor should also be renamed to siteProvider, see public MultiSiteRegexpVirtualURIMapping(SiteProvider siteFunctions) |
| Comment by Christopher Zimmermann [ 01/Jun/15 ] |
|
Dang, fixed. |