[MULTISITE-59] Use injection instead of Components.getComponent() where possible/useful Created: 08/Dec/15  Updated: 01/Feb/16  Resolved: 26/Jan/16

Status: Closed
Project: Magnolia Multisite Module
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2.3

Type: Improvement Priority: Neutral
Reporter: Philip Mundt Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1.5h
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Sprint: Basel 28
Story Points: 2

 Description   

There are quite a few classes that still make heavy use of Components.getComponent() in the module where we should instead use injection and IoC.

The following classes can be adjusted:

  • info.magnolia.multisite.CrossSiteAbsolutePathTransformer and info.magnolia.multisite.DomainNamePathTransformer
    • info.magnolia.cms.beans.config.ServerConfiguration and
    • info.magnolia.cms.beans.config.URI2RepositoryManager should be injected
  • info.magnolia.multisite.MultiSiteURI2RepositoryManager
    • info.magnolia.module.site.SiteManager and
    • javax.inject.Provider<info.magnolia.cms.core.AggregationState> should be injected
  • info.magnolia.multisite.MultiSiteRootVirtualURIMapping
    • info.magnolia.module.site.functions.SiteFunctions should be injected

Generated at Mon Feb 12 06:06:01 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.