[MULTISITE-69] MultisteFilter cleanURI is not taking into account all possible cases for site roots Created: 23/Nov/16  Updated: 16/Dec/16  Resolved: 14/Dec/16

Status: Closed
Project: Magnolia Multisite Module
Component/s: None
Affects Version/s: 1.2
Fix Version/s: 1.2.5

Type: Bug Priority: Neutral
Reporter: Jaroslav Simak Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.5h
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-6882 Remove legacy code that allows to acc... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Kromeriz 74
Story Points: 3

 Description   

Multisite filter checks in clearURI method for homepage by comparing uri to /siteName.html. If uri matches the /siteName.html, handle in aggregation state is then set to /. However that is not the only case for resolving the homepage, we should cover other cases and set / handle for them as well:

  • /siteName
  • /siteName/
  • /siteName~my=awesome~selector~.html
  • /siteName~my=awesome~selector~

Check for /siteName.html is not sufficient. We might consider to add rule for matching the /siteName.html or /siteName~my=awesome~selector~.html that users can activate for SEO purposes (prevent duplicate content).

We also need to improve checks in info.magnolia.multisite.sites.matchers.NotEmptyHandleMatcher. Current behavior is erroneous because we only check for startsWith handlePrefix, thus pages like /travel, /travel0, /travelSomething matches the handlePrefix.


Generated at Mon Feb 12 06:06:07 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.