[MULTISITE-87] Recent changes to NotEmptyUriPrefixMatcher removed the possibility to configure subsites for a domain Created: 11/May/18  Updated: 31/Jul/18  Resolved: 17/May/18

Status: Closed
Project: Magnolia Multisite Module
Component/s: None
Affects Version/s: 1.2.20, 1.3.1, 1.3.2, 1.3.3
Fix Version/s: None

Type: Bug Priority: Critical
Reporter: Bence Vass Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
duplicate
duplicates MULTISITE-86 Site not matched correctly if page an... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

There have been recent changes to the NotEmptyUriPrefixMatcher class, according to this ticket: https://jira.magnolia-cms.com/browse/MULTISITE-80

Since then, this class doesn't do anymore what its name (NotEmptyUriPrefixMatcher) suggests, because it will also match sites that have an empty URIPrefix.

The description of the rule "domain-and-uri-prefix-not-empty" says: Domain and not empty uri prefix (subsites)

So you cannot configure subsites anymore, this is a very critical issue, please fix this asap.

(there is only one workaround atm: order the subsite above the mainsite in the site definitions, and hope that the order is never reversed during matchin by whatever mechanism)



 Comments   
Comment by Bence Vass [ 11/May/18 ]

I just noticed, this issue has already been reported 2 months ago in MULTISITE-86

 

Comment by Antti Hietala [ 17/May/18 ]

Duplicates MULTISITE-86

Comment by Jaroslav Simak [ 23/May/18 ]

Hi bvass

would it be possible to get some sample config for this issue?

Thanks.

Comment by Bence Vass [ 23/May/18 ]

Hi, you need two site configurations:

F.e. travel demo with a multi tree configuration:
http://travel.demo.magnolia-cms.com - this is the english page
http://travel.demo.magnolia-cms.com/de  - this is the german page

travel
  domains
    travel-demo
      name - travel.demo.magnolia-cms.com
  mappings
    website
      URIPrefix
      handlePrefix - /travel
      repository - website

travelDE
  domains
    travel-demo
      name - travel.demo.magnolia-cms.com
    mappings
      website
        URIPrefix - /de
        handlePrefix - /travelDE
        repository - website

Generated at Mon Feb 12 06:06:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.