[MURLTRANS-9] URL-Translation always resolves wrong language Created: 31/Jul/19  Updated: 18/Mar/21  Resolved: 20/Aug/19

Status: Closed
Project: URL Translation
Component/s: None
Affects Version/s: 6.1
Fix Version/s: None

Type: Bug Priority: High
Reporter: Thomas Peintner Assignee: Richard Gange
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MURLTRANS-8 Base module should depend on multisite Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Hi, we are currently using a Magnolia 6.1 Multisite installation with German as default language, everywhere, and English as second. 

When we do an upgrade from the URL-Translation version 5.6.2 to version 6.1 we face the problem, that the module is only resolving URLs with the English path.

Downgrade to version 5.6.2 solves the issue and it is working as expected



 Comments   
Comment by Philip Müller [ 15/Jun/20 ]

@Richard Gange
Hi. I'm having the same issue right now. I compared the code of I18nLinkTransformerManager and can see that the following changed:

MgnlContext.getAggregationState().getLocale(); was replaced by MgnlContext.getLocale()

With 5.7 the locale call returned the correct current locale. With 6.2 the locale call returns the locale of the logged in user, which is for example english, but im viewing the french page /fr/page, so the links are transformed wrongly. Am I missing something?

Comment by Richard Gange [ 15/Jun/20 ]

Hello pmueller-

It's controlled by the site definition. Most often I am finding that users are missing the fallback locale. Have a look at the travel demo configuration.

HTH
Rich

Comment by Philip Müller [ 15/Jun/20 ]

Our fallback locale is de, and all other locales are defined properly. It worked with 5.7. It's not working with 6.2 and the newest url-trans module. The site is resolved properly. Should I open a support ticket?

Comment by Richard Gange [ 15/Jun/20 ]

Yes please

Comment by Thomas Peintner [ 10/Aug/20 ]

For us the solution was to copy the classes I18nLinkTransformerManager and TranslateAbsolutePathTransformer from the multi url translation module

and change MgnlContext.getLocale() to MgnlContext.getAggregationState().getLocale(), as Philip already mentioned in de comments. 

Our upgrade path is from 6.0-> 6.1->6.2 in every version it wasn't working proper without overriding the classes.

Comment by Richard Gange [ 10/Aug/20 ]

When you go from 5/6.0 to 6.1 there is changes in dependency when it comes to the site and multisite modules. I think this might be creating an issue. See MURLTRANS-8. I hope to someday either merge the modules or URL Translation makes it into the product as a core feature. It is currently on the roadmap.

HTH
Rich

Comment by David Escudero [ 18/Mar/21 ]

We have the same Issue, our fallback Language is ES and module resolves to EN

How i can resolve the problem?

This only happens in public instance. 

Generated at Mon Feb 12 11:08:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.