[NPMBUILD-1] node build-script extraction Created: 10/Dec/15  Updated: 27/Jan/16  Resolved: 06/Jan/16

Status: Closed
Project: Magnolia light-module build tools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Espen Jervidalo Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 3h
Original Estimate: Not Specified

Attachments: File build.js    
Issue Links:
dependency
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Light mods packaging + dependancies
Sprint: Kromeriz 26
Story Points: 5

 Description   

The npm POC currently has an example project which includes a build script. The script should be extracted and only be called from the project. The script should be cleaned up or rewritten.

naming of keyword: magnolia-light-modules ?
don't hardcode light-modules directory



 Comments   
Comment by Jan Haderka [ 14/Dec/15 ]

Link to the branch w/ poc code pls?

Comment by Espen Jervidalo [ 16/Dec/15 ]

As discussed, please make it a standalone node module and put it into git somewhere.

Comment by Espen Jervidalo [ 22/Dec/15 ]

One tiny thing: Jan suggested using 'magnolia-light-module' instead of 'light-module' as the keyword.

Comment by Jan Haderka [ 04/Jan/16 ]

Could you please QA this to make sure it works as expected? Thx.

Comment by Espen Jervidalo [ 05/Jan/16 ]

As discussed:
Please use dependencies instead of devDependencies.

Comment by Jan Haderka [ 11/Jan/16 ]

So is it reviewed or do we have still code changes pending? Can you reflect that in a status properly?

Generated at Mon Feb 12 06:00:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.