[NPMBUILD-8] Make the light modules search algorithm more subtle Created: 12/Feb/16  Updated: 07/Mar/16  Resolved: 25/Feb/16

Status: Closed
Project: Magnolia light-module build tools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Maxime Michel Assignee: Maxime Michel
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1.5h
Original Estimate: Not Specified

Issue Links:
causality
caused by NPMBUILD-2 When name: @magnolia/<lightmodule> ma... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Sprint: Basel 33
Story Points: 2

 Description   

NPMBUILD-2 extended the light modules search algorithm so that it would find scoped modules (@magnolia/light-module). However, as discovered by Espen (https://git.magnolia-cms.com/projects/BUILD/repos/npm-build-tools/pull-requests/4/overview?commentId=3183), a brute recursive search is a bit overkill. This ticket should solve this, by:

  • scanning for scoped packages (detecting '@…' packages)
  • therefore getting rid of the dependency on wrench?

Generated at Mon Feb 12 06:00:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.