[NPMCLI-185] Add an npm-shrinkwrap.json file to CLI to ensure proper functioning Created: 06/Jun/18  Updated: 24/Mar/22  Resolved: 24/Mar/22

Status: Closed
Project: Magnolia CLI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: Christopher Zimmermann Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to NPMCLI-182 CLI jumpstart fails - due to regressi... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

WIthout this file, the build will get different versions of dependencies and therefore might have functionality broken.

See:

https://docs.npmjs.com/files/shrinkwrap.json

 

For example see the problem that occurred here:

 https://jira.magnolia-cms.com/browse/NPMCLI-182



 Comments   
Comment by Christopher Zimmermann [ 07/Jun/18 ]

Im not sure - but I think it makes a difference which version of node you are on when you run the shrinkwrap command, since the dependencies may depend on the version of node. In that case, run shhrinkwrap while running the lowest version of node that we support - to ensure that the final CLI works on the most possible versions of node for our customers.

Generated at Mon Feb 12 04:47:21 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.