[NPMCLI-241] Fix CLI to not create invalid definitions on 6.2 Created: 30/Jul/20  Updated: 10/Mar/21  Resolved: 10/Mar/21

Status: Closed
Project: Magnolia CLI
Component/s: None
Affects Version/s: 3.1.0
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Christopher Zimmermann Assignee: Robert Šiška
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
supersession
is superseded by NPMCLI-236 Update to M6 definitions and also sup... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Epic Link: Content Types phase 2
Sprint: HL & LD 23, HL & LD 24
Story Points: 0

 Description   

The CLI create-content-type and create-app commands specify incorrect definitions. in the app definition. 

They should be changed so that the CLI does not create a broken definition. 

This definition will not work and cause log issues on 6.2.*

https://git.magnolia-cms.com/projects/BUILD/repos/npm-cli/browse/lib/config/mgnl-cli-prototypes/app/_default/apps/__name__.yaml

# Optionally override any of the app configuration supplied by the content type.
# subApps:
#   detail:
#     editor:
#       form:
#         tabs:
#           default:
#
#             fields:
#               - name: title
#                 rows: 5

Also please verify that the other commands and prototypes do not create invalid defintions that send warnings to the log or create 'problems' in the definitions app.



 Comments   
Comment by Christopher Zimmermann [ 24/Feb/21 ]

Have a look at this highly related PR:

https://git.magnolia-cms.com/projects/BUILD/repos/npm-cli/pull-requests/131/

I think it would make sense to address this related ticket as soon as possible: https://jira.magnolia-cms.com/browse/NPMCLI-236

Comment by Christopher Zimmermann [ 09/Mar/21 ]

Stories block definition - should have a comment to indicated which version of Magnoila it supports - ie >=6.2.7 or >=6.2.8

Generated at Mon Feb 12 04:47:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.