[NPMCLI-26] Define prototype for light module in _prototypes directory instead of config file Created: 14/Jul/16  Updated: 19/Jan/17  Resolved: 19/Jan/17

Status: Closed
Project: Magnolia CLI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Unassigned
Resolution: Not an issue Votes: 0
Labels: blocked
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to NPMCLI-20 Update mgnl-cli.json "lightDevFolders... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

It would be more intuitive to customize the directory structure of a light module by simply editing folders and files in a new directory in the _prototype directory.

So the new structure could be:

  • _prototype
    • component
    • module
    • page

The module directory would contain the boilerplate folder structure, plus any files that you always want included (like bootstrap, jquery, etc).



 Comments   
Comment by Tomáš Gregovský [ 15/Jul/16 ]

Good idea, but currently there is LM folder structure not only defined in package.json becasue of generating it, but there are also some another events connected to it. for example to move specific resources which are provided with another npm package. e.g. jquery:

"lightDevFoldersInModule":

{ "js": "/webresources/js" }

,
"dependencies":

{ ... "jquery": "^2.2.3", ... }

,
"lightDevCopyResources":

{ "jquery/dist/jquery.js": "js" }
Comment by Christopher Zimmermann [ 18/Jul/16 ]

Thanks, I see. Maybe this ticket does not make sense then, I'll mark as blocked and think about it.

Comment by Robert Kowalski [ 19/Jan/17 ]

hi czimmermann - is the ticket still relevant?

Comment by Christopher Zimmermann [ 19/Jan/17 ]

Closing based on tgregovsky rational in comment.

Generated at Mon Feb 12 04:45:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.