[NPMCLI-40] Get rid of module specifier for the 2nd argument of add-availability (and -a option for create-component) Created: 25/Jul/16 Updated: 04/Apr/17 Resolved: 21/Mar/17 |
|
| Status: | Closed |
| Project: | Magnolia CLI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christoph Meier | Assignee: | Robert Kowalski |
| Resolution: | Obsolete | Votes: | 1 |
| Labels: | quickwin | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Basel 88 | ||||||||
| Story Points: | 0.5 | ||||||||
| Description |
|
mgnl-add-availability has the following synopsis: mgnl-add-availability <[refId/]componentName> <[moduleName:relPath/]page@area> [options]
This said, the 2nd argument how it is explained in the synopis can be simplified. And indeed: The same is true for the -a option when calling create-component: |
| Comments |
| Comment by Christoph Meier [ 25/Jul/16 ] |
|
Maybe tgregovsky and or fgrilli can "review" this request for simplification - just to make sure i haven't missed a point which makes the module specifier indispensable. |
| Comment by Christopher Zimmermann [ 25/Jul/16 ] |
|
I like this suggestion. I came to the same conclusion independently. It makes understanding the commands easier because there is only one way to refence the page. (Also the module specifier does not work correctly under some circumstances.) I am updating the linked ticket to reflect this improvement. |
| Comment by Christoph Meier [ 25/Jul/16 ] |
|
I propose the following (new) Synopis aka Usage: <[<module-id:>]relPath/component> <relPath/page@area> [options] ... or something similar. |
| Comment by Chetan [ 11/Aug/16 ] |
|
Hi I am getting error in using Magnolia CLI tool: My NPM version is: My Node.js version is: nacon@nacon-004:~$ mgnl create-light-module my-module -p light-modules/ |
| Comment by Christoph Meier [ 12/Aug/16 ] |
|
chetan1590 Besides that, your issue doesn't seem to be related with this ticket here where you have just commented. |
| Comment by Robert Kowalski [ 21/Mar/17 ] |
|
I think this was fixed in |