[NPMCLI-42] Magnolia install broken on Java 8 due to Neat Resources Created: 26/Jul/16  Updated: 22/Aug/16  Resolved: 29/Jul/16

Status: Closed
Project: Magnolia CLI
Component/s: None
Affects Version/s: None
Fix Version/s: 0.0.1

Type: Bug Priority: Major
Reporter: Christopher Zimmermann Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The jumpstart command itself works and gets what it should, but Magnolia has errors during install and will not start due to the default configuration which loads the Neat Resources jar into the lib directories. This jar depends on Java 8
https://github.com/rah003/neat-resources
(https://nexus.magnolia-cms.com/service/local/repositories/magnolia.forge.releases/content/com/neatresults/mgnltweaks/neat-resources/1.0.1/neat-resources-1.0.1.jar)

Some possiblities on how to handle:

  • Notify users who run jumpstart that Java 8 JRE is required.
  • Neat Resources should provide better logging - and possibly skip install if Java 8 is not present.
  • Make Neat Resources work on Java 8.
  • Do not include this jar by default.

Snippet from log

2016-07-26 10:07:56,324 ERROR org.apache.commons.digester.Digester              : Body event threw exception
org.apache.commons.beanutils.ConversionException: Error converting from 'String' to 'Class' com/neatresults/mgnltweaks/resources/setup/NeatR
esourcesModuleVersionHandler : Unsupported major.minor version 52.0 (unable to load class com.neatresults.mgnltweaks.resources.setup.NeatRes
ourcesModuleVersionHandler)
        at org.apache.commons.beanutils.converters.AbstractConverter.handleError(AbstractConverter.java:282)
        at org.apache.commons.beanutils.converters.AbstractConverter.convert(AbstractConverter.java:177)
        at org.apache.commons.beanutils.converters.ConverterFacade.convert(ConverterFacade.java:61)
        at org.apache.commons.beanutils.ConvertUtilsBean.convert(ConvertUtilsBean.java:491)
        at org.apache.commons.beanutils.ConvertUtils.convert(ConvertUtils.java:251)
        at org.apache.commons.betwixt.strategy.ConvertUtilsObjectStringConverter.stringToObject(ConvertUtilsObjectStringConverter.java:67)



 Comments   
Comment by Christoph Meier [ 27/Jul/16 ]

The dependency for Java 8 could indeed be a reason to get rid of neat-resources (imho).

Comment by Jan Haderka [ 29/Jul/16 ]

Magnolia 5.5 supports only Java 8. We are releasing CLI 1.0 with and for Magnolia 5.5, so java 8 should NOT be reason for kicking anything out. That said I have no problem of getting rid of the module for any other reason.

Comment by Christoph Meier [ 29/Jul/16 ]

Thanks for your comment Jan.
However, this ticket is anyway obsolete.

The broken install was first due to a too low Java version. Then we had issues with some slash / backslash within magnolia.properties.
But now it works all as a charm (bzw. wie Schmidts Katze )
I will close this ticket as obsolete now.

So, the question to keep or not to keep is really "independent".

I was not aware that npm-cli (1.0) will not be released before Magnolia 5.5 - i expected it to be released independent (and before M5.5).

If we keep neat-resources - we must recommend Java8 . which is totally fine.

Comment by Christoph Meier [ 29/Jul/16 ]

czimmermann
When using a up-to-date Java 8 version - the bundled install by the jumpstart command enriched with neat-resources starts up properly and works fine.
To keep or not to keep neat-resources is not an issue but just a general decision.
The broken install at the end was because of the backslash in the magnolia.properties - which has been resolved by NPMCLI-43

Installing neat-resources or not, depending on the Java version "could" be an approach, but for this i rather would file another ticket, if we really want that.

Comment by Christoph Meier [ 29/Jul/16 ]

See last comment.

Generated at Mon Feb 12 04:45:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.