[NPMCLI-44] jumpstart command should not create the "sampleModule" per default. Created: 28/Jul/16 Updated: 22/Aug/16 Resolved: 09/Aug/16 |
|
| Status: | Closed |
| Project: | Magnolia CLI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 0.0.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christoph Meier | Assignee: | Christoph Meier |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1d | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Sprint: | Basel 56 |
| Story Points: | 2 |
| Description |
|
The jumpstart creates a light module named sampleModule per default. I would find it "better" if a light module is only created by this command, if the -i, --install-sample-module <name> option is provided. |
| Comments |
| Comment by Tomáš Gregovský [ 04/Aug/16 ] |
|
Hi, I guess "sampleModule" is now used only when 'jumpstart'. And since in current project concept we are not using json configuration (mgnl-cli.json) for managing/creating specific light module that much as it was originally, I would suggest remove "create-light-module" from jumpstart. so you will have to type two commands instead of one (seems it more logical now). And because you have to type LM name as part of 'cgnl create-light-module' command, then we don't need "sampleModule" e.g. "lightModuleName" property in configuration at all. I would also like to see when you finish jumpstart or 'mgnl setup' printed message like "Now you can continue creating your light module running a command: mgnl create-light-module <moduleName>" etc... |
| Comment by Christoph Meier [ 04/Aug/16 ] |
|
I agree in all points said by Tomáš in the comment before. |
| Comment by Christopher Zimmermann [ 04/Aug/16 ] |
|
Sounds good to me. |