[NPMCLI-46] Jumpstart command does not update the magnolia.resources.dir property for light modules folder Created: 11/Aug/16  Updated: 22/Aug/16  Resolved: 12/Aug/16

Status: Closed
Project: Magnolia CLI
Component/s: None
Affects Version/s: None
Fix Version/s: 0.0.1

Type: Bug Priority: Critical
Reporter: Edwin Guilbert Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: regression
Remaining Estimate: 0d
Time Spent: 3h
Original Estimate: Not Specified
Environment:

NodeJs 4.4.7
NPM-CLI 0.0.1-snapshot-85
OSX 10.11.6


Issue Links:
relation
is related to NPMCLI-37 Install shows deprecation warnings in... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Basel 56
Story Points: 1

 Description   

The jumpstart command doesn't update the

magnolia.resources.dir

in magnolia.properties located at

apache-tomcat/webapps/magnoliaAuthor/WEB-INF/config/default

with the right location of the light-modules folder created by jumpstart.

Steps to reproduce:

  1. Run: mgnl jumpstart
    INFO: Using configuration at /usr/local/lib/node_modules/@magnolia/cli/lib/config/mgnl-cli.json
    INFO: Using prototypes at /usr/local/lib/node_modules/@magnolia/cli/lib/config/mgnl-cli-prototypes
    INFO: No path option provided. Will use the default 'light-modules' in the current directory
    INFO: No magnolia-version option provided. Will use the latest Community Edition
    INFO: '/Users/ebguilbert/tmp/jira-npm/light-modules' does not seem to exist. Path will be created automatically.
    Downloading...
    
  2. When finished check the bottom of messages:
    Extracting...
    magnolia-5.4.8/apache-tomcat-7.0.64/ to /Users/ebguilbert/tmp/jira-npm/apache-tomcat
    Extraction completed
    Replacing Magnolia properties to prepare it for light development...
    Changing magnolia.properties at apache-tomcat/webapps/magnoliaAuthor/WEB-INF/config/default as follows:
    magnolia.develop=true
    magnolia.update.auto=true
    magnolia.resources.dir=/Users/ebguilbert/tmp/jira-npm/light-modules
    Downloading neat-resources-1.0.1.jar [====================] 100% 0.0s
    DONE: Magnolia has been successfully setup for light development!
    You can now go to 'apache-tomcat/bin' and start up Magnolia by entering './magnolia_control.sh start' Magnolia will be ready after a few seconds at localhost:8080/magnoliaAuthor. Username and password is superuser
    To stop Magnolia enter './magnolia_control.sh stop'. On Windows use magnolia_control.bat
    
    neat-resources-1.0.1.jar copied to WEB-INF/lib/ of Magnolia webapps
    
  3. Run: cd apache-tomcat/webapps/magnoliaAuthor/WEB-INF/config/default
  4. Check the magnolia.resources.dir property:
    $ grep "magnolia.resources.dir=" magnolia.properties 
    magnolia.resources.dir=${magnolia.home}
    


 Comments   
Comment by Federico Grilli [ 11/Aug/16 ]

Good catch! This failed due to the fact that I had to change the find&replace npm package we used with a different one, cause the previous one pulled in a dependency with a security issue. The new library behaves slightly differently from the old one, hence the failure. I'll also write some unit tests to avoid regressions like that in the future.

Generated at Mon Feb 12 04:46:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.