[NPMCLI-46] Jumpstart command does not update the magnolia.resources.dir property for light modules folder Created: 11/Aug/16 Updated: 22/Aug/16 Resolved: 12/Aug/16 |
|
| Status: | Closed |
| Project: | Magnolia CLI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 0.0.1 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Edwin Guilbert | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | regression | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3h | ||
| Original Estimate: | Not Specified | ||
| Environment: |
NodeJs 4.4.7 |
||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Basel 56 | ||||||||
| Story Points: | 1 | ||||||||
| Description |
|
The jumpstart command doesn't update the magnolia.resources.dir in magnolia.properties located at apache-tomcat/webapps/magnoliaAuthor/WEB-INF/config/default with the right location of the light-modules folder created by jumpstart. Steps to reproduce:
|
| Comments |
| Comment by Federico Grilli [ 11/Aug/16 ] |
|
Good catch! This failed due to the fact that I had to change the find&replace npm package we used with a different one, cause the previous one pulled in a dependency with a security issue. The new library behaves slightly differently from the old one, hence the failure. I'll also write some unit tests to avoid regressions like that in the future. |