[NPMCLI-49] mgnl-cli.json improvements Created: 31/Aug/16 Updated: 28/Nov/16 Resolved: 24/Nov/16 |
|
| Status: | Closed |
| Project: | Magnolia CLI |
| Component/s: | None |
| Affects Version/s: | 0.0.2 |
| Fix Version/s: | 1.0.6 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Tomáš Gregovský | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Sprint: | Basel 71 |
| Story Points: | 1 |
| Description |
|
while doing 'mgnl setup' and going to edit mgnl-cli.json I see and may edit 'downloadUrl' for Magnolia tomcat, but instead of version number I see ${magnoliaVersion} and this one is not editable in mgnl-cli.json which probably will be nice to have, or don't use this property at all. Don't we have on nexust something for always downloading latest version? Maybe this will be useful instead of changing default cli configuration everytime new Magnolia version is released. Another question: is "lightModuleName": "sampleModule" used anywhere by CLI tool? It seems like after latest changes in create-light-module and jumpstart this is not used, so then I would suggest to remove it from mgnl-cli.json ... Thank you |
| Comments |
| Comment by Christoph Meier [ 31/Aug/16 ] |
|
tgregovsky, right now, when executing jumpstart, one can provide the -m, --magnolia-version <version> option, if not provided, the latest version is taken. We could change that in a way, that we add the Magnolia version property to the mgnl-cli.json with a default "LATEST". The way we call the nexus REST api contains the parameter v (the version of the Maven artifact) which can be a real version or LATEST To finish with a side note: I guess we anyway will have to enhance the jumpstart command and what it downloads. At some point we should support npm-cli that it downloads the "special bundle" for Magnolia NOW local development. This will be an artifact which will reside in a not public repository - this said npm-cli jumpstart must know the credentials to pass to nexus. (See NPMCLI-50) |
| Comment by Federico Grilli [ 24/Nov/16 ] |
|
As mentioned by Christoph, {${magnoliaVersion}} is a placeholder, whose default value is LATEST. If you one wants to download a different version, jumpstart has the -m option. I would not change anything here. |