[NPMCLI-51] Jumpstart command should set magnolia.develop to true Created: 15/Sep/16  Updated: 22/Sep/16  Resolved: 19/Sep/16

Status: Closed
Project: Magnolia CLI
Component/s: None
Affects Version/s: 0.0.1
Fix Version/s: 0.0.2

Type: Bug Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: regression
Remaining Estimate: 0d
Time Spent: 3h
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Basel 62
Story Points: 1

 Description   

Using the beta version, the magnolia.develop property in magnolia.properties does not get set to true.

Once fixed will require release of 0.0.2 beta + update of README.md



 Comments   
Comment by Federico Grilli [ 15/Sep/16 ]

I confirm the issue. Since we had to replace replace with replace-in-file (forgive the pun) due to NPMCLI-37 the latter is giving weird issues, like e.g. NPMCLI-46 and this one. The regex and replacement produced by our code work fine, as you can see at https://regex101.com/r/uG4uS2/1 yet when used with that npm replace-in-file in this particular case does not work, whereas updating magnolia.resources.dir and magnolia.update.auto does work. Also I noticed that magnolia.properties file itself is screwed at the very bottom like this

[omitted]
# Set it to true if bootstrapping/update should be performed automatically
magnolia.update.auto=true

# Location of the file containing both the private and the public keys used to verify authenticity of activation requests
# This file is generated if not present
magnolia.author.key.location=${magnolia.home}/WEB-INF/config/default/magnolia-activation-keypair.properties

fig/default/magnolia-activation-keypair.properties
Generated at Mon Feb 12 04:46:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.