[NPMCLI-56] fs module referenced downloads spam Created: 26/Nov/16 Updated: 05/Dec/16 Resolved: 28/Nov/16 |
|
| Status: | Closed |
| Project: | Magnolia CLI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.6 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Robert Kowalski | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Sprint: | Basel 72 |
| Story Points: | 1 |
| Description |
|
The current package.json references the module "fs" version 0.0.2 as dependency. This comes from a time where the npm registry allowed to publish modules with Node core module names. The problem is that the module does not make any sense and installs an annoying spam message:
$ cat node_modules/fs/index.js
console.log("I'm `fs` modules");
The assumption is that the intention is to not install the module and that it was a mistake. Further reference: http://status.npmjs.org/incidents/dw8cr1lwxkcr |
| Comments |
| Comment by Robert Kowalski [ 26/Nov/16 ] |
|
Decided for no tests as already covered by other integration tests. |
| Comment by Federico Grilli [ 28/Nov/16 ] |
|
Hello Robert, Thanks for creating this issue and providing a patch. Very much appreciated. |