[NPMCLI-6] Do not duplicate areas Created: 05/Apr/16  Updated: 17/Nov/17  Resolved: 17/Nov/17

Status: Closed
Project: Magnolia CLI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Tomáš Gregovský Assignee: Federico Grilli
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: CLI v3
Sprint: Basel 122
Story Points: 1

 Description   

Currently add-availability script when it doesn't find proper area in yaml configuration (page definition) will create this configuration and into ftl file will add freemarker code to render that area. Unfortunately for pages we have one ftl file - main.ftl and if add-availability for compA into homePage it will does it (add area configuration, add ftl to render area). But then if add-availability for compB to standardPage which share same main.ftl, then this area is added into ftl again (duplication).

So modify add-availability script to first check if that area '[#cms.area name="<areaName>" ' (do not close, there can be extra parameters for area) already exist in ftl file.



 Comments   
Comment by Tomáš Gregovský [ 20/Jul/16 ]

still issue

Generated at Mon Feb 12 04:45:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.