[NPMCLI-89] Remove shim wrapper around "commander" once #name function PR is merged Created: 31/Jan/17  Updated: 24/Mar/22

Status: Open
Project: Magnolia CLI
Component/s: None
Affects Version/s: 2.1.1
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Cedric Reichenbach Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by NPMCLI-28 The help text for the commands are in... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

Because the commander library doesn't have a chainable setter for the name property, we created a PR on GitHub for that. As a workaround in the meantime, we created a custom node module `commander_shimmed.js`, which provides a wrapper providing desired behavior through a mild hack.

Once above PR is merged,

  • Delete `commander_shimmed.js`
  • Update commander version in `package.json`
  • Replace all `require`s of `commander_shimmed` by `commander` again


 Comments   
Comment by Cedric Reichenbach [ 31/Jan/17 ]

Marked as blocked until related PR on GitHub is merged.

Comment by Cedric Reichenbach [ 10/Jul/17 ]

Unblocked as PR has finally been merged: https://github.com/tj/commander.js/pull/605

Generated at Mon Feb 12 04:46:25 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.