[NPMCLI-89] Remove shim wrapper around "commander" once #name function PR is merged Created: 31/Jan/17 Updated: 24/Mar/22 |
|
| Status: | Open |
| Project: | Magnolia CLI |
| Component/s: | None |
| Affects Version/s: | 2.1.1 |
| Fix Version/s: | None |
| Type: | Task | Priority: | Neutral |
| Reporter: | Cedric Reichenbach | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoR: |
Empty
|
||||||||
| Description |
|
Because the commander library doesn't have a chainable setter for the name property, we created a PR on GitHub for that. As a workaround in the meantime, we created a custom node module `commander_shimmed.js`, which provides a wrapper providing desired behavior through a mild hack. Once above PR is merged,
|
| Comments |
| Comment by Cedric Reichenbach [ 31/Jan/17 ] |
|
Marked as blocked until related PR on GitHub is merged. |
| Comment by Cedric Reichenbach [ 10/Jul/17 ] |
|
Unblocked as PR has finally been merged: https://github.com/tj/commander.js/pull/605 |